support concurrent prepasses #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 97.3% 97.31% +<.01%
==========================================
Files 10 10
Lines 483 484 +1
Branches 87 87
==========================================
+ Hits 470 471 +1
Misses 9 9
Partials 4 4
Continue to review full report at Codecov.
|
kitten
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that we have a new hook after we throw inside of a custom-hook, this results in the
useMemohook (for this scenario) being a conditional hook. This is a "violation" against the rules-of-hooks however this should be supported in React as well since they'll probably throw away the result of that render.Fixes: #34