Replace CJS-only build with ESM and CJS w/o NODE_ENV #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: This can't safely use package.json:exports since react isn't an ESM build and this would lead to issues as per the standard ESM module resolution which must start only resolving .mjs by default once it hits an ESM package.
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 95.93% 95.93%
=======================================
Files 12 12
Lines 516 516
Branches 90 89 -1
=======================================
Hits 495 495
Misses 19 19
Partials 2 2
Continue to review full report at Codecov.
|
JoviDeCroock
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23