Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for mouse events #52

Closed
wants to merge 1 commit into from

Conversation

jakepusateri
Copy link

Fixes #51

@goatslacker
Copy link
Contributor

This library was meant for touch and not for mouse. I appreciate the PR, perhaps you can fork the project and add it in?

@goatslacker goatslacker closed this Oct 4, 2016
@jakepusateri
Copy link
Author

What about 'swipeable' means 'only touch events'? For a user with only a mouse, click + drag is a swipe.

If this needs to be an opt-in feature, I can add that option.

@pie6k
Copy link

pie6k commented Oct 9, 2016

@goatslacker Whats wrong with making mouse support optional?

@hartzis
Copy link
Collaborator

hartzis commented Oct 9, 2016

I didn't realize devices like the surface pro treat the touch pen as a mouse. I think this is an interesting idea and do think this could be added as an opt-in feature.

@goatslacker how do you feel about adding this as an opt-in feature?

@goatslacker
Copy link
Contributor

I'll defer to your judgement @hartzis opt-in is fine.

@hartzis
Copy link
Collaborator

hartzis commented Oct 13, 2016

@jakepusateri do you think you could make another PR with this as an opt in via a prop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants