This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Fix dependencies #78
Merged
Fix dependencies #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,7 +72,7 @@ export default class App extends React.Component { | |||
| <VictoryAxis | |||
| label="time axis" | |||
| padding={{left: 10, right: 80}} | |||
| scale={"time"} | |||
| scale={d3Scale.time()} | |||
There was a problem hiding this comment.
actually no, with the most recent refactor, d3-scale is not a dependency of victory-axis. It is now possible to pass a string scale, and have victory-util interpret that into a d3-scale. If a user would like to pass a d3-scale function anyhow, that will now be something they would include in their app.
There was a problem hiding this comment.
So the fix should be to add String as a valid propType for scale?
Edit: nevermind, my victory-util was out of date. npm install!!
coopy
force-pushed
the
task-commonDeps
branch
from
f3d94a6 to
968afda
Compare
added 2 commits
January 22, 2016 13:15
- Add Radium & Lodash to dependencies - Add React to peerDependencies
coopy
force-pushed
the
task-commonDeps
branch
from
968afda to
2853a57
Compare
|
thanks @coopy I forgot about the docs! LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d3-scaleas dependency; update docsReactas peerDependencyPart of FormidableLabs/victory#176