Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Fix dependencies #93

Merged
merged 3 commits into from
Jan 27, 2016
Merged

Fix dependencies #93

merged 3 commits into from
Jan 27, 2016

Conversation

coopy
Copy link
Contributor

@coopy coopy commented Jan 21, 2016

  • react is a real dependency
  • move radium and lodash from archetype to project

Part of FormidableLabs/victory#176

@boygirl
Copy link
Contributor

boygirl commented Jan 21, 2016

I'm a little confused about the react and react-dom deps, but you've been keeping better track of all the builder stuff than me, so approved

@coopy
Copy link
Contributor Author

coopy commented Jan 21, 2016

Thanks for pointing that out, @boygirl! React is an application dep, but ReactDom isn't, since it's only used to generate demo/docs.

Edit: React is a peerDependency. Updated to reflect that!

- Add Radium, Lodash to dependencies
- Add React as peerDependency
coopy pushed a commit that referenced this pull request Jan 27, 2016
@coopy coopy merged commit 68c0bcd into master Jan 27, 2016
@coopy coopy deleted the task-commonDeps branch January 27, 2016 02:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants