This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Make zoom optional in VictoryZoom closes #429 #416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an allowZoom prop to VictoryZoom component (default to
true
to keep current behaviour). This is a pretty naive implementation of the wanted behaviour, I guess we could just add/remove the event listeners whenallowZoom
changes at runtime (and thus avoid a rerender), but that would imply making bigger changes, and I'm not sure it's needed.Moreover, I fixed the indentation of the demo, I was struggling to understand where each example started and finished! But I can easily remove these changes from this commit!
If this is good for you, I'll create a PR on the docs repo.