Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Make zoom optional in VictoryZoom closes #429 #416

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Make zoom optional in VictoryZoom closes #429 #416

merged 1 commit into from
Nov 21, 2016

Conversation

AugustinLF
Copy link
Contributor

Add an allowZoom prop to VictoryZoom component (default to true to keep current behaviour). This is a pretty naive implementation of the wanted behaviour, I guess we could just add/remove the event listeners when allowZoom changes at runtime (and thus avoid a rerender), but that would imply making bigger changes, and I'm not sure it's needed.

Moreover, I fixed the indentation of the demo, I was struggling to understand where each example started and finished! But I can easily remove these changes from this commit!

If this is good for you, I'll create a PR on the docs repo.

@boygirl
Copy link
Contributor

boygirl commented Nov 21, 2016

@AugustinLF this works perfectly. Thank you!

@boygirl boygirl merged commit 0c685af into FormidableLabs:master Nov 21, 2016
@AugustinLF AugustinLF deleted the feature/pan-only-victory-zoom branch November 22, 2016 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants