This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Fix Throttle In Containers #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NgoKnows
force-pushed
the
fix-throttle-in-containers
branch
from
8332ad0 to
432ccf1
Compare
|
@boygirl did a bit more digging, and noticed that if we can avoid rerendering all of the |
|
@NgoKnows This all looks good to me. Approved! Can you open a separate issue about optimizing label rendering for VictoryVoronoiContainer? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the throttling of events in the
victory-*-containers. Something else I noticed was that the trailing call of the throttled functions doesn't actually apply the mutations, so the trailing call isn't needed. This also removes the need tocancelthe throttled functions and the need to persist events.