This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
add downsample prop to VictoryZoomContainer #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
with downsample and without, on 5,000 points. 15 FPS vs. 0.75 FPS. 20x improvement.
|
boygirl
suggested changes
Jul 28, 2017
| @@ -70,6 +78,10 @@ export const zoomContainerMixin = (base) => class VictoryZoomContainer extends b | |||
| } | |||
| }]; | |||
|
|
|||
| constructor(props) { | |||
There was a problem hiding this comment.
oh total mistake!
| // core downsampling algo | ||
|
|
||
| // important: assumes data is ordered by dimension | ||
| // get the start and end of the data that is in the current visible domain |
There was a problem hiding this comment.
You can check on the sortKey prop
…wnsampleZoomFriendly
chrisbolin
force-pushed
the
downsample-zoom
branch
from
b41a4ee to
40b5e8a
Compare
|
Requires FormidableLabs/victory-core#276 now |
boygirl
reviewed
Jul 28, 2017
| if (startIndex !== 0) { startIndex -= 1; } | ||
| if (endIndex !== -1) { endIndex += 1; } | ||
|
|
||
| const visableData = data.slice(startIndex, endIndex); |
There was a problem hiding this comment.
NIT: visableData -> visibleData
boygirl
approved these changes
Aug 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downsampleprop onVictoryZoomContainer.Downsamples according to the
dimensionprop (defaults to"x"if dimension is not set).Assumes data is sorted by dimension. (which is the case with almost all large time-series data) Need to make sure we note this in the docs.
Performance gains are pretty great...
Before: 1,000 points render at 3.5 FPS.
After: 100,000 render at 8 FPS.