This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes for Containers
This PR changes the names of several container props so that there is no naming conflict. This was an issue for users using the
createContainer
helper. Props likedimension
that had the same name across containers were not able to be individually assigned in hybrid containers. Issues like FormidableLabs/victory#756 would occur as a consequence.Naming Changes:
VictoryBrushContainer
dimension
->brushDimension
selectionComponent
->brushComponent
selectedDomain
->brushDomain
selectionStyle
->brushStyle
onDomainChange
->onBrushDomainChange
VictoryCursorContainer
dimension
->cursorDimension
onChange
->onCursorChange
VictorySelectionContainer
dimension
->selectionDimension
VictoryVoronoiContainer
dimension
->voronoiDimension
VictoryZoomContainer
dimension
->zoomDimension
onDomainChange
->onZoomDomainChange