Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

no props name overlap for containers #518

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Sep 26, 2017

Breaking Changes for Containers

This PR changes the names of several container props so that there is no naming conflict. This was an issue for users using the createContainer helper. Props like dimension that had the same name across containers were not able to be individually assigned in hybrid containers. Issues like FormidableLabs/victory#756 would occur as a consequence.

Naming Changes:

VictoryBrushContainer

  • dimension -> brushDimension
  • selectionComponent -> brushComponent
  • selectedDomain -> brushDomain
  • selectionStyle -> brushStyle
  • onDomainChange -> onBrushDomainChange

VictoryCursorContainer

  • dimension -> cursorDimension
  • onChange -> onCursorChange

VictorySelectionContainer

  • dimension -> selectionDimension

VictoryVoronoiContainer

  • dimension -> voronoiDimension

VictoryZoomContainer

  • dimension -> zoomDimension
  • onDomainChange -> onZoomDomainChange

@boygirl boygirl merged commit 869dddc into master Sep 27, 2017
@boygirl boygirl deleted the improvement/unique-container-props branch September 27, 2017 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant