This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 76
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
24 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,7 +47,6 @@ export default class VictoryContainer extends React.Component { | |
|
||
componentWillMount() { | ||
this.savePortalRef = (portal) => this.portalRef = portal; | ||
this.saveSvgRef = (svg) => this.svgRef = svg; | ||
this.portalUpdate = (key, el) => this.portalRef.portalUpdate(key, el); | ||
this.portalRegister = () => this.portalRef.portalRegister(); | ||
this.portalDeregister = (key) => this.portalRef.portalDeregister(key); | ||
|
@@ -97,8 +96,7 @@ export default class VictoryContainer extends React.Component { | |
const svgProps = assign( | ||
{ | ||
"aria-labelledby": "title desc", role: "img", width, height, | ||
viewBox: responsive ? `0 0 ${width} ${height}` : undefined, | ||
ref: this.saveSvgRef | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
boygirl
Author
Contributor
|
||
viewBox: responsive ? `0 0 ${width} ${height}` : undefined | ||
}, | ||
events | ||
); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@boygirl Can you explain why this was removed please?