This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Add optional title and desc elements to victory-label #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For accessibility reason it would be nice to add
<title>and<desc>tags tovictory-label. This is helpful, for example, if the normal label text is truncated (for space reasons) and one wants to provide the full title in a browser tooltip.This PR adds
titleanddescprops tovictory-label. They are optional and render their respective SVG tags only when provided. There is also an example added in thedemo/folder.