This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Improvement/victory container #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
<g>rendering fromVictoryContainerto reduce confusion over evented containers. Closes FormidableLabs/victory#539This PR also renders an additional outer svg wth
overflow="visible"so that anything rendered withinVictoryPortalwill be allowed to overflow the svg container (i.e. tooltips). Anything rendered in the inner svg element will still be clipped as normal (unlessoverflow: "visible"is explicitly added to parent styles). Closes FormidableLabs/victory#524This PR also adds a
renderInPortalprop toVictoryLabel. It works like the same prop inVictoryTooltipbut defaults to false. Clipped data components (VictoryArea and VictoryLine) addrenderInPortalto their default label components. Closes FormidableLabs/victory#521This PR also changes the default responsive styles to
width: "100%", height: "100%"to address an issue with incorrectly rendered containers in safari. This PR also re-orders style defaults so that these responsive styles may be overridden by explicitly addingwidthandheightattrs to parent styles.