This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Victory-bar handles switching the x and y scales for horizontal bars in getCalculatedValues:
Currently, the getBarWidth function switches them again to calculate width:
Because of this, horizontal Bars rendered by VictoryBar actually end up using their VictoryBar's xScale to determine their widths. This results in the following bug:
|
--- | ---
This patch remediates the problem by always using scale.x in getBarWidth, under the assumption that scale.x will in fact be a parent VictoryBar's yScale if the Bar is horizontal.