Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

BREAKING CHANGE: VictoryTooltip should not have a default theme #293

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Aug 22, 2017

fixes FormidableLabs/victory#719

this will be a breaking change for people who are using their own themes, but not defining any tooltip theme. To compensate for this change, add the following to your theme object:

tooltip: {
    style: assign({}, centeredLabelStyles, { padding: 5, pointerEvents: "none" }),
    flyoutStyle: {
      stroke: charcoal,
      strokeWidth: 1,
      fill: "#f0f0f0",
      pointerEvents: "none"
    },
    cornerRadius: 5,
    pointerLength: 10
  }

@boygirl boygirl changed the title VictoryTooltip should not have a default theme BREAKING CHANGE: VictoryTooltip should not have a default theme Aug 23, 2017
@boygirl boygirl merged commit f71b1ee into master Aug 23, 2017
@boygirl boygirl deleted the bug/default-tooltip-theme branch August 23, 2017 03:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip Styling inside VictoryVoronoiContainer
1 participant