This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Update tooltips rendered in portal. Fix #793. #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix issue #793 Tooltips in VoronoiContainer stay showing after leaving chart. Tooltips rendered in a portal were not being removed because
render
was never being called on the<Portal />
component after the portal was "deregistered." Callingthis.forceUpdate
after unregistering the portal forces a re-render, which returns an empty object for thechildren
that should be rendered in the portal and removes the tooltip. For example:Notice that the tooltips are being rendered in the
<Portal />
, but they are properly unmounting when the user leaves the bounding area.Local tests for this code were performed using the
lank
workflow, i.e. changes were made tovictory-core
and tested usingvictory-voronoi-container-demo.js
from a sibling local version ofvictory-chart
. To get the tooltips to render in the portal, comment out this line fromvictory-voronoi-container.js
in your local install ofvictory-chart
.