This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Render line on top of area so it isn't partially hidden #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this could get looked at? |
|
@jlongster sorry about that. You caught me on vacation! This looks great. I'll get it released for Monday |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Area component currently renders the stroke element below the area. This causes weird effects like this:
Don't see here? Here, let me bump up the stroke width:
The issue is that half of the bar is hidden underneath the area. Even without this visual glitch, if you give it a
strokeWidthof 10 it's only going to show 5 pixels because the area is hiding half of it.Here's how it looks with my fix:
I can't see why this was intentional, so hopefully this is an easy merge. Let me know if there's anything else I can do!