This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
[ENH] Add sortOrder prop #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naveenblipp Thanks. I will release your change in |
boygirl
suggested changes
Dec 17, 2017
| const data = range(9).map((i) => ({ x: i, y: i })); | ||
|
|
||
| const wrapper = shallow( | ||
| <VictoryPie data={data} sortKey={"x"} sortOder={"descending"}/> |
There was a problem hiding this comment.
typo sortOder -> sortOrder
There was a problem hiding this comment.
@naveenblipp I couldn't figure out why CI was still failing after releasing your change in victory-core. Pesky typos. Approved pending this change.
|
@boygirl Ah, sorry for those typos. Fixes the tests now. |
boygirl
approved these changes
Dec 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: FormidableLabs/victory#870
This fix uses the new
sortOrderkey. We can specify theascendingordescendingorder forsortKeyTests will fail until we upgrade victory-core dependency with fix from FormidableLabs/victory-core#322
Thanks!