Skip to content

Commit

Permalink
Update to the latest version of pnpm in corepack (#2969)
Browse files Browse the repository at this point in the history
  • Loading branch information
carbonrobot authored Nov 15, 2024
1 parent 31ae615 commit 8d7c0bf
Show file tree
Hide file tree
Showing 4 changed files with 13,900 additions and 10,441 deletions.
4 changes: 1 addition & 3 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@ inputs:
runs:
using: "composite"
steps:
- uses: pnpm/action-setup@v3
with:
version: 7
- uses: pnpm/action-setup@v4

- name: Use Node.js
uses: actions/setup-node@v4
Expand Down
25 changes: 14 additions & 11 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@ Victory is a monorepo built with [Wireit](https://github.com/google/wireit) and
### Requirements

- [Node.js](https://nodejs.org/) 18 or higher.
- [pnpm](https://pnpm.io/) 7.

> [!Note]
> If you have a different pnpm version installed locally you can still use version 7 by prefixing the commands with `npx pnpm@7`.
> For example, `npx pnpm@7 install`.
- [pnpm](https://pnpm.io/) version specified by [corepack](https://github.com/nodejs/corepack) in the `package.json`.

### Setup

Expand All @@ -35,11 +31,15 @@ $ git clone https://github.com/FormidableLabs/victory.git
$ cd victory
```

Enable corepack (if not already):

```sh
$ corepack enable
```

Use [pnpm](https://pnpm.io/) to install dependencies:

```sh
# ... if you need pnpm
$ npm install -g pnpm
$ pnpm install
```

Expand All @@ -49,12 +49,15 @@ $ pnpm install

We have some dev servers available for a sample development environment.

> Note: The demo app is deprecated, all development should occur in storybook or the docs
```sh
# TypeScript demo app
$ pnpm start
```
# watch mode / HMR
$ pnpm storybook:dev

These run appropriate file watchers, so you can just start developing source files and wait for the webpack dev server to pick up the new changes.
# storybook standalone
$ pnpm storybook:start
```

### Running Docs locally

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"url": "https://github.com/formidablelabs/victory/issues"
},
"homepage": "https://commerce.nearform.com/open-source/victory",
"packageManager": "pnpm@7.33.7",
"packageManager": "pnpm@9.13.0",
"dependencies": {
"clsx": "^2.1.1"
},
Expand Down
Loading

0 comments on commit 8d7c0bf

Please sign in to comment.