VictoryBrushContainer should not show "rezise-cursor" when allowResize is false

[johnhydroware]

The Problem

When "VictoryBrushContainer" and setting "allowResize" to "false" the cursor still changes to a double-arrow-cursor in the edges of the brush. It should only show the "hand" since moving the brush is the only available action for the user.

[boygirl]

Good catch, thank you!

[erick2014]

Hello, I want to try to solve this

[boygirl]

@erick2014 thanks! Please let me know if you have any questions about how to get started :)

[erick2014]

Sure, thanks a lot

[erick2014]

hey @boygirl is there any way to reproduce this issue? I'm new in this and I have no idea what does the VictoryBrushContainer means

[narinluangrath]

Hi @erick2014, here's a demo of the VictoryBrushContainer: https://formidable.com/open-source/victory/docs/victory-brush-container/

The BrushContainer adds a highlighted region to the chart on the bottom. The allowResize prop controls whether or not it can be resized. Ideally, when the user hovers over the edge of the highlighted region and allowResize is set to false, the cursor shouldn't switch to the "resize" symbol since the user isn't allow to resize it.

[erick2014]

owww, thankyou so much @narinluangrath

[erick2014]

@johnhydroware would be helpful if you u share some code and pictures for better understanding

[erick2014]

@boygirl I sent a pr for this issue https://github.com/FormidableLabs/victory/pull/1124/files, hope this helps

[erick2014]

@boygirl you can close this issue now