Change cursor when allowResize and allowDrag are false #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erick2014 thanks for helping out! There are a couple issues with this, though. I'm including a gif to illustrate what I'm talking about:
|
boygirl
suggested changes
Sep 24, 2018
boygirl
reviewed
Sep 24, 2018
|
|
||
| if (!props.allowResize && props.allowDrag) { | ||
| xProps = assign(xProps, { cursor: "move" }); | ||
| yProps = assign(yProps, { cursor: "auto" }); |
There was a problem hiding this comment.
Should these both be "move" ?
|
@boygirl thx for your help, check it now |
boygirl
suggested changes
Sep 25, 2018
| }; | ||
| if (!props.allowResize && props.allowDrag) { | ||
| cursors.xProps = "move"; | ||
| cursors.yProps = "auto"; |
There was a problem hiding this comment.
I still think these should both be "move". If you disagree can you explain why not?
There was a problem hiding this comment.
yeah, I agree, because if you can't resize, but you can drag, makes sense
|
🎉 Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes VictoryBrushContainer should not show "rezise-cursor" when allowResize property is false, #1095