Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VictoryLegend - TypeError when no props provided. #520

Closed
marthix opened this issue Mar 15, 2017 · 0 comments · Fixed by FormidableLabs/victory-core#221
Closed

VictoryLegend - TypeError when no props provided. #520

marthix opened this issue Mar 15, 2017 · 0 comments · Fixed by FormidableLabs/victory-core#221
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@marthix
Copy link

marthix commented Mar 15, 2017

If you add VictoryLegend to a project, without providing it any props, it throws the following error:

TypeError: Cannot read property 'map' of undefined
at VictoryLegend.getCalculatedProps (.../node_modules/victory-core/lib/victory-legend/victory-legend.js:129:19)

Seems it isn't receiving its default props as expected, and thus there are no props to iterate over via the map causing the undefined error.
@boygirl boygirl added the Type: Bug 🐛 Oh no! A bug or unintentional behavior label Mar 16, 2017
@boygirl boygirl mentioned this issue Mar 16, 2017
Merged
boygirl added a commit that referenced this issue Jul 17, 2018
@boygirl
Merge pull request #520 from FormidableLabs/feature/allow-pan
b1308e2 
add allowPan prop for VictoryZoomContainer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix legend bugs FormidableLabs/victory-core
2 participants
@boygirl @marthix