Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty arrays for VictoryLabel's style prop cause an error #904

Closed
boygirl opened this issue Jan 17, 2018 · 1 comment
Closed

Empty arrays for VictoryLabel's style prop cause an error #904

boygirl opened this issue Jan 17, 2018 · 1 comment
Assignees
@parkerziegler

Comments

@boygirl
Copy link
Contributor

boygirl commented Jan 17, 2018

When an empty array is given as the value for style in VictoryLabel, a fallback value should be used instead.
@parkerziegler parkerziegler self-assigned this Jan 17, 2018
@parkerziegler
Copy link
Contributor

This should be taken care of by this PR. I'll update the PR description to include it.

@parkerziegler parkerziegler reopened this Jan 18, 2018
@boygirl boygirl closed this as completed Jan 19, 2018
boygirl added a commit that referenced this issue Jul 17, 2018
@boygirl
Merge pull request #328 from parkerziegler/feature/inline-multi-label
73534d4 
Add support for inlining multiple text and passing an array via the lineHeight prop. Features for #893, #902, and #904.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parkerziegler parkerziegler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boygirl @parkerziegler