Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/bar width #1078

Merged
merged 4 commits into from
Aug 5, 2018
Merged

Improvement/bar width #1078

merged 4 commits into from
Aug 5, 2018

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Aug 5, 2018

This PR:

  • Adds barWidth and candleWidth ratios to VictoryBar and VictoryCandlestick respectively. These props should be used in place of width on styles. This change was made because width as it is used in these components is not a standard svg style attribute. This change should reduce confusion.
  • Does not deprecate the use of width in styles for VictoryBar or VictoryCandlestick, however, the new props will take precedence.
  • Adds a candleRatio prop that works the same was as barRatio
  • Cleans up methods and props on Bar and Candle primitive components

@boygirl boygirl merged commit 4e1481e into master Aug 5, 2018
@boygirl boygirl deleted the improvement/barWidth branch August 5, 2018 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant