Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for controlling
radius
,innerRadius
,cornerRadius
,padAngle
,sliceStartAngle
andsliceEndAngle
for each individual slice of a pie:Details:
The
Slice
primitive used byVictoryPie
now takesradius
,cornerRadius
,innerRadius
,padAngle
,sliceStartAngle
andsliceEndAngle
props. Each of these props may be given as number or a function ofdatum
andactive
.padAngle
,radius
,cornerRadius
andinnerRadius
will be passed down from props onVictoryBar
, butsliceStartAngle
andsliceEndAngle
must be defined directly on theSlice
instance, These values should be given in degrees. To make these values easier to use as functional props,startAngle
,endAngle
, andpadAngle
(in degrees) are added to eachdatum
passed intoSlice
. (If your data already has these properties they will not be overridden)Breaking Changes
The
Slice
primitive will still take apathFunction
prop, but this prop will no longer be provided byVictoryPie
. This will not be a breaking change for most users. This will only affect users who were wrapping theSlice
component and making use of thepathFunction
prop provided byVictoryPie
Users who were providing their ownpathFunction
prop toSlice
should not be effected.closes #1136