Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar): Bar chart is missing bar for the first value #1202

Merged
merged 3 commits into from
Dec 14, 2018

Conversation

scottdickerson
Copy link
Contributor

fix(helper-method) getBaseProps incorrect handles when eventKey is 0 and loses the data. Only fail over to the index if the eventKey is truly null or undefined.

Closes issue #1175

@boygirl
Copy link
Contributor

boygirl commented Dec 14, 2018

@scottdickerson thanks!

@boygirl boygirl merged commit 9a72c95 into FormidableLabs:master Dec 14, 2018
@galamo
Copy link

galamo commented Jan 9, 2019

Hi
after updating to version victory@31.1.0
getting error: Cannot read property 'x' of undefined on BarChart component
the code working fine with prev versions
i updated the package due to the missing BarChart values.

i saw the issue coming from categories object at getAxisProps function
x axis is timestamp

any idea ?

@scottdickerson
Copy link
Contributor Author

@galamo can you make a simple repo in code sandbox for us to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants