Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove componentWillReceiveProps #1238

Closed
wants to merge 5 commits into from
Closed

Remove componentWillReceiveProps #1238

wants to merge 5 commits into from

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Jan 23, 2019

This PR removes cWRP and uses sCU for animation and event driven updates while also adding sCU logic to prevent unnecessary renders. Unfortunately, sCU logic is not as robust as it could be because function props are appearing unequal.

@boygirl
Copy link
Contributor Author

boygirl commented Jan 25, 2019

closing in favor of #1239

@boygirl boygirl closed this Jan 25, 2019
@boygirl boygirl deleted the experiment/cDU branch January 28, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@boygirl