-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/audit victory candlestick typescript props #1512
Task/audit victory candlestick typescript props #1512
Conversation
@wsparsons I'm seeing some errors when running |
@boygirl I accidentally imported the wrong file. let me push up some of the current fixes. I am still working through the rest of the errors |
9f16bc9
to
cb9b9f9
Compare
7bf2884
to
3ca09ca
Compare
@wsparsons This is looking great! Just a couple small comments to resolve, then good to go. |
… are already defined in VictoryCommonProps and VictoryDatableProps
3ca09ca
to
d4f7172
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What it does?
VictoryCandlestick
VictoryCandlestickDemo
VictoryCandlestickProps
VictoryCommonProps
andVictoryDatableProps
samples
,sortOrder
, andrange
props fromVictoryCommonProps
andVictoryScatterProps
since they are defined in the common interfaces.labels
from the demo