Add missing DefinitelyTyped props to VictorySlice and VictoryPie #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
boygirl
reviewed
Apr 29, 2020
packages/victory-pie/src/index.d.ts
Outdated
|
|
||
| export type innerRadiusType = | ||
| | number | ||
| | (( |
There was a problem hiding this comment.
This function should get the full list of VictoySliceProps like others
boygirl
reviewed
Apr 29, 2020
packages/victory-pie/src/index.d.ts
Outdated
| colorScale?: ColorScalePropType; | ||
| cornerRadius?: number; |
There was a problem hiding this comment.
cornerRadius should also take a function
boygirl
suggested changes
Apr 29, 2020
boygirl
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following props:
VictorySlice:
VictoryPie: