Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds backgroundComponent prop to VictoryChartProps interface #1572

Merged
merged 1 commit into from
May 14, 2020
Merged

Adds backgroundComponent prop to VictoryChartProps interface #1572

merged 1 commit into from
May 14, 2020

Conversation

wsparsons
Copy link
Member

@wsparsons wsparsons commented May 14, 2020 •
edited
Loading

Adds the missing backgroundComponent prop to VictoryChartProps interface #1558

@wsparsons wsparsons requested a review from boygirl May 14, 2020 01:01
@wsparsons wsparsons changed the title Adds background prop to VictoryChartProps interface Adds backgroundComponent prop to VictoryChartProps interface May 14, 2020
@boygirl
Copy link
Contributor

boygirl commented May 14, 2020

@wsparsons thank you for this quick fix. I'm going to merge and release this now in case it might be blocking your native work.

@boygirl boygirl merged commit 2ad39e9 into master May 14, 2020
@boygirl boygirl deleted the task/add-backgroundComponent branch June 23, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boygirl boygirl Awaiting requested review from boygirl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wsparsons @boygirl