Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass rx and ry to Background if provided #1767

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Pass rx and ry to Background if provided #1767

merged 2 commits into from
Jan 5, 2021

Conversation

NgoKnows
Copy link
Member

@NgoKnows NgoKnows commented Jan 5, 2021

This PR adds passing along rx and ry to the rect the Background primitive renders.

Screen Shot 2021-01-04 at 5 18 54 PM

boygirl
boygirl suggested changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@boygirl boygirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NgoKnows! Mind adding those props to the propTypes and the BackgroundProps interface in victory-core/src/index.d.ts?

@NgoKnows
Copy link
Member Author

NgoKnows commented Jan 5, 2021

@boygirl yes, done!

@boygirl
Copy link
Contributor

boygirl commented Jan 5, 2021

Thanks! I'll release a patch for you right now :)

@boygirl boygirl merged commit 1d22111 into main Jan 5, 2021
@boygirl boygirl deleted the bugfix/pass-rx-ry-to-background branch January 5, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boygirl boygirl boygirl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NgoKnows @boygirl