-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add radium, lodash to devDeps; react to peerDeps #179
Conversation
Approved! |
Maybe lax up the react requirements to: |
@austinpray We can't guarantee that Victory works with future React releases, though, can we? |
this looks good to me! thanks @coopy @austinpray I don't think we can do that until future version of React is released. we support all 0.14.x which is good |
You can't guarantee compatibility with 14+, but by doing this you are guaranteeing incompatibility. I would lax requirements and perhaps drop a warning in the console for versions greater than 14. |
@alexlande -- Can you comment on Radium's choice to not have a |
@ryan-roemer: Afraid I can't speak to it much. The change was made in this PR: FormidableLabs/radium#242 I expect the reasoning was that at the time there was a lot of confusion going around re: It's in the |
See README for explanation.
This adds application dependencies (`radium`, `lodash`) to the projects.
2ad3fd0
to
18c9e52
Compare
@austinpray Thanks for the comment! I removed the I added some documentation instead: https://github.com/FormidableLabs/builder-victory-component/#peerdependencies |
Add radium, lodash to devDeps; react to peerDeps
Fixes #176