Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting only x or only y values for VictoryTooltip center prop #1812

Merged
merged 2 commits into from
Apr 2, 2021
Merged

allow setting only x or only y values for VictoryTooltip center prop #1812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74c3c3d
allow setting only x or only y values for VictoryTooltip center prop
boygirl Apr 2, 2021
a3809a8
update node version matrix
boygirl Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ cache: yarn
addons:
chrome: stable
node_js:
- "10"
- "12"
- "14"
sudo: false
branches:
only:
Expand Down Expand Up @@ -58,7 +58,7 @@ after_success:
jobs:
include:
- stage: documentation
node_js: '12'
node_js: '14'
script:
# Only do the docs build/deploy if docs changes.
# We early terminate the entire job which should also skip `deploy` tasks.
Expand Down
2 changes: 1 addition & 1 deletion packages/victory-tooltip/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export interface VictoryTooltipProps extends VictoryLabelableProps {
activateData?: boolean;
activePoints?: any[];
angle?: string | number;
center?: { x: number; y: number };
center?: { x: number | undefined; y: number | undefined };
centerOffset?: {
x?: NumberOrCallback;
y?: NumberOrCallback;
Expand Down