Axis Prop Updates

[jhumbug]

This provides a fix for when the domain of a dataset using VictoryZoom changes, such as switching out data on demand.

[jhumbug]

@boygirl Seems like this was a very simple fix. Suspiciously simple. But I couldn't find any unintended consequences of fixing it like this. Any insights on your end?

[jhumbug]

I looked into what you mentioned about offsetX and offsetY on Chart and Axis, but that didn't seem to be related as far as I could tell.

[boygirl]

@jhumbug apologies! I think this does fix a portion of the issue, but I should have been clearer about the axis offset issue. Here's a gif that I think illustrates the problem:

In the chart above, there are not user provided xOffset / yOffset props. The offsets are being calculated by VictoryChart based on the domain. At the beginning, the offsets are calculated correctly so that the axes intersect at (0, 0), However, when zooming, these offsets aren't changing, because VictoryZoomContainer alters the domain prop for all the children of VictoryChart, but not for VictoryChart itself.

[jhumbug]

Ok, yeh I missed that. I will look into that part of it now, thank you for the gif.

[boygirl]

From looking at the stories, it looks like there's a systematic problem with horizontal charts and with how the range / padding is being calculated

[jhumbug]

From looking at the stories, it looks like there's a systematic problem with horizontal charts and with how the range / padding is being calculated

Yep, addressing those now. Most are the horizontal issue which is easy. I'll look at range/padding after.

[jhumbug]

Got most of the chromatic issues with those fixes. I'll work on the few left tomorrow.

[jhumbug]

The last chromatic changes are from added/changed tests in previous PRs and 2 (VictoryScatter: Theme & VictoryLine: Theme) that actually look correct now, rather than the previous version. They have slight differences in the grid position, but it looks like the new versions are right now, no?

[boygirl]

@jhumbug A couple minor comments, but this is otherwise looking ready. And axes look so much nicer when zooming