Patch missing text component type #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Thanks so much @youPickItUp ! I'll get this merged in, and it should go out with the next release. |
becca-bailey
changed the base branch from
main
to
patch-missing-text-component-type
|
It looks like the chromatic and doc deploy failures are happening because Github isn't able to run these actions from a PR opened from a fork. I'm going to merge this to a Victory branch first just to make sure these checks are running. |
becca-bailey
merged commit c77206b
into
FormidableLabs:patch-missing-text-component-type
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed the docs and typescript were missing the
textComponentprop onVictoryLabelwhich I needed to overwrite.Here is PR fixing that.