Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

victory-pie jest/rtl tests #2268

Merged
merged 2 commits into from
May 30, 2022
Merged

Conversation

heythisispaul
Copy link
Contributor

Part of #2195 - this PR migrates the existing victory-pie unit tests to Jest and RTL.

Copy link
Contributor

@becca-bailey becca-bailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Super tiny comments.

test/jest/victory-pie/victory-pie.test.js Outdated Show resolved Hide resolved
test/svg-test-helper.js Outdated Show resolved Hide resolved
@heythisispaul heythisispaul merged commit 6bff0c8 into main May 30, 2022
@heythisispaul heythisispaul deleted the feature/victory-pie-jest-tests branch May 30, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants