Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS migration: victory-primitives #2274

Merged
merged 10 commits into from
Jun 1, 2022
Merged

TS migration: victory-primitives #2274

merged 10 commits into from
Jun 1, 2022

Conversation

scottrippey
Copy link
Member

Migrates all victory-primitives to TypeScript

@scottrippey scottrippey marked this pull request as ready for review May 31, 2022 21:40
Base automatically changed from typescript-dts to main June 1, 2022 02:22
scottrippey added 2 commits June 1, 2022 11:45
# Conflicts:
#	packages/victory-core/src/victory-primitives/point.tsx
Copy link
Contributor

@becca-bailey becca-bailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@scottrippey scottrippey merged commit ca8e2a2 into main Jun 1, 2022
@scottrippey scottrippey deleted the ts-migration branch June 1, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants