Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React to v18 #2280

Merged
merged 15 commits into from
Jun 3, 2022
Merged

Upgrade React to v18 #2280

merged 15 commits into from
Jun 3, 2022

Conversation

becca-bailey
Copy link
Contributor

@becca-bailey becca-bailey commented Jun 1, 2022

Upgrades React to v18, and updates peer dependencies to work with React 18. (Are there any reasons for us to remove support for v16 right now?)

This also updates a few misc. dependency issues that came up when running yarn audit.

Fixes #2187

@becca-bailey becca-bailey force-pushed the chore/upgrade-react branch from d577c81 to e89f71d Compare June 2, 2022 20:34
@becca-bailey becca-bailey marked this pull request as ready for review June 2, 2022 20:41
@becca-bailey
Copy link
Contributor Author

@scottrippey I didn't update any lint rules in this PR, but for some reason eslint-typescript is throwing a bunch of warnings in CI. Any ideas why?

package.json Show resolved Hide resolved
packages/victory-area/package.json Outdated Show resolved Hide resolved
Copy link
Member

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@becca-bailey becca-bailey merged commit 0893e58 into main Jun 3, 2022
@becca-bailey becca-bailey deleted the chore/upgrade-react branch June 3, 2022 18:10
@stur86
Copy link

stur86 commented Jun 7, 2022

Great! When can we expect a new release on NPM including this fix?

@becca-bailey
Copy link
Contributor Author

@stur86 Apologies for the delay in getting this released, we have been resolving some build issues on our end, but this should go out before the end of this week.

@stur86
Copy link

stur86 commented Jun 7, 2022

Thanks, that's fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 18 support?
3 participants