Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demo]: Upgrade React Native demo app #2288

Merged
merged 2 commits into from
Jun 6, 2022
Merged

[Demo]: Upgrade React Native demo app #2288

merged 2 commits into from
Jun 6, 2022

Conversation

jpdriver
Copy link
Contributor

@jpdriver jpdriver commented Jun 4, 2022

  • @scottrippey recently reported that the RN Demo no longer runs on physical devices
  • Expo regularly drop older SDK versions from their Expo Go app
  • this PR bumps package versions but leaves the demo /src untouched
Package Before After
expo ~42.0.1 ~45.0.0
react 16.13.1 17.0.2
react-native https://github.com/expo/react-native/archive/sdk-42.0.0.tar.gz 0.68.2

Screenshots

Before After
IMG_3188 IMG_3189

scottrippey
scottrippey approved these changes Jun 4, 2022
View reviewed changes
Copy link
Member

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

gksander
gksander approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

demo/rn/App.tsx Show resolved Hide resolved
@jpdriver jpdriver merged commit 8ec3199 into main Jun 6, 2022
@jpdriver jpdriver deleted the jp-upgrade-rn-demo branch June 6, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gksander gksander gksander approved these changes

@scottrippey scottrippey scottrippey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpdriver @scottrippey @gksander