-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests to root directories #2301
Conversation
packages/victory-core/src/victory-accessible-group/victory-accessible-group.test.tsx
Show resolved
Hide resolved
…riding correctly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (But I've only done a quick skim -- let's see what @scottrippey says :) )
@scottrippey I think there is still an issue here where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard work, but good job!
Runs well locally.
Once the build is passing LGTM!
Notes for later -- here are all of our relative imports from tests:
|
Build enhancements for move tests PR
# Conflicts: # package-scripts.js # packages/victory-area/.npmignore # packages/victory-axis/.npmignore # packages/victory-bar/.npmignore # packages/victory-box-plot/.npmignore # packages/victory-brush-container/.npmignore # packages/victory-brush-line/.npmignore # packages/victory-candlestick/.npmignore # packages/victory-canvas/.npmignore # packages/victory-chart/.npmignore # packages/victory-core/.npmignore # packages/victory-core/src/victory-util/events.test.js # packages/victory-core/src/victory-util/events.test.ts # packages/victory-core/src/victory-util/prop-types.test.js # packages/victory-core/src/victory-util/prop-types.test.ts # packages/victory-core/src/victory-util/scale.test.ts # packages/victory-create-container/.npmignore # packages/victory-cursor-container/.npmignore # packages/victory-line/.npmignore # packages/victory-native/.npmignore # packages/victory-pie/.npmignore # packages/victory-polar-axis/.npmignore # packages/victory-scatter/.npmignore # packages/victory-selection-container/.npmignore # packages/victory-shared-events/.npmignore # packages/victory-stack/.npmignore # packages/victory-tooltip/.npmignore # packages/victory-voronoi/.npmignore # test/jest/victory-core/victory-util/events.test.js # test/jest/victory-core/victory-util/prop-types.test.js
This is the initial work to move test files into the packages they are testing. I ran into some complications around build config, detailed in comments below.