Add Victory Bar v37 #2316
Merged
Add Victory Bar v37 #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 17, 2022 16:05
There will probably be some tricky logic here for handling default props and getting props from child components. Rather than iterating through children to grab props, we will be setting top-level props from the child components. But we will need to make some decisions about how to keep track of individual props, whether child props override parent props, and when to set state.
becca-bailey
commented
Jun 22, 2022
scottrippey
approved these changes
Jun 22, 2022
added 3 commits
June 23, 2022 10:36
… tested For now, we should only run stories in /stories in the chromatic UI tests. Any stories we are adding in /packages are just WIP demos to help with refactoring, and they don't need to be tested in chromatic. If we co-locate stories in victory packages, we need to revert this change.
becca-bailey
modified the milestone:
Replace class inheritance with component composition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality will work for rendering either one standalone
VictoryBarcomponent or a single nestedVictoryBarcomponent nested under aVictoryChart.As discussed, we will need to add functionality for two-way syncing between child props and the provider props so the provider knows about the props of each child component and we can support multiple datasets in child components.
Right now all new components live inside the
v37directories, so this should not touch any existing behavior.