Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: migrate victory to TypeScript #2319

Merged
merged 3 commits into from
Jun 23, 2022
Merged

TypeScript: migrate victory to TypeScript #2319

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f69d61
chore(typescript): migrate `victory` to TypeScript
Jun 21, 2022
ccc06dc
Merge remote-tracking branch 'origin/main' into ts-migrate/victory
Jun 22, 2022
bf3d441
chore(prettier): added trailing commas
Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
282 changes: 0 additions & 282 deletions packages/victory/src/index.d.ts
View file
Open in desktop

This file was deleted.

14 changes: 14 additions & 0 deletions packages/victory/src/index.js → packages/victory/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,32 +57,45 @@ export { VictoryVoronoi, Voronoi } from "victory-voronoi";
export { VictoryBrushLine } from "victory-brush-line";
export {
VictoryBrushContainer,
// @ts-expect-error Missing types for this export
BrushHelpers,
// @ts-expect-error Missing types for this export
brushContainerMixin
scottrippey marked this conversation as resolved.
Show resolved Hide resolved
} from "victory-brush-container";
export {
VictoryCursorContainer,
// @ts-expect-error Missing types for this export
CursorHelpers,
// @ts-expect-error Missing types for this export
cursorContainerMixin
} from "victory-cursor-container";
export {
VictorySelectionContainer,
// @ts-expect-error Missing types for this export
SelectionHelpers,
// @ts-expect-error Missing types for this export
selectionContainerMixin
} from "victory-selection-container";
export {
VictoryVoronoiContainer,
// @ts-expect-error Missing types for this export
VoronoiHelpers,
// @ts-expect-error Missing types for this export
voronoiContainerMixin
} from "victory-voronoi-container";
export {
VictoryZoomContainer,
// @ts-expect-error Missing types for this export
ZoomHelpers,
// @ts-expect-error Missing types for this export
zoomContainerMixin,
// @ts-expect-error Missing types for this export
RawZoomHelpers
} from "victory-zoom-container";
export {
// @ts-expect-error Missing types for this export
combineContainerMixins,
// @ts-expect-error Missing types for this export
makeCreateContainerFunction,
createContainer
} from "victory-create-container";
Expand All @@ -97,5 +110,6 @@ export {
CanvasCurve,
CanvasPoint,
CanvasBar,
// @ts-expect-error Missing types for this export
useCanvasContext
} from "victory-canvas";
Loading