-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Wireit: TypeScript #2349
[WIP] Wireit: TypeScript #2349
Conversation
…rence in `devDeps`
Great start! Was able to run $ pnpm -r --filter victory-core run types:create and see the types output Some directions for us from here:
|
For the "copy es to lib" approach, we're getting these output messages:
Now things still run very quickly, but I do wonder if there's any higher level impact on things? Bouncing back and forth between UPDATE: I updated and not sure if this is still happening. Will check again! UPDATE 2: Latest changes show this is not an issue. Ignore! |
@scottrippey if you want to enable CI on this PR you can do: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 18614bcb..76b19acf 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -7,12 +7,16 @@ on:
push:
branches:
- main
+ # TODO(wireit): Remove before merge.
+ - pnpm-wireit
paths:
- '**'
- '!docs/**'
pull_request:
branches:
- main
+ # TODO(wireit): Remove before merge.
+ - pnpm-wireit
paths:
- '**'
- '!docs/**' I'm seeing failures in |
What
Adds TypeScript to build:
pnpm run types:create:pkgs
Creates all.d.ts
files. Ignores tests. Ignores errors, for ease-of-development's sake.pnpm run types:check:pkgs
Checks types for all packages, including tests. Does NOT ignore errors.Work
types:create
andtypes:check
scripts