Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: migrate victory-brush-container and victory-brush-line #2393

Merged
merged 13 commits into from
Aug 3, 2022

Conversation

ramenhog
Copy link
Contributor

@ramenhog ramenhog commented Jul 28, 2022

This PR migrates victory-brush-container and victory-brush-line over to TypeScript

@ramenhog ramenhog mentioned this pull request Aug 1, 2022
30 tasks
@ramenhog ramenhog changed the title Ts migrate/victory brush TS: migrate victory-brush-container and victory-brush-line Aug 1, 2022
@ramenhog ramenhog marked this pull request as ready for review August 2, 2022 21:33
Copy link
Member

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some tiny comments, then LGTM

ramenhog and others added 2 commits August 2, 2022 16:26
Co-authored-by: Scott Rippey <scottrippey@users.noreply.github.com>
@ramenhog ramenhog merged commit ee87ebc into main Aug 3, 2022
@github-actions github-actions bot mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants