Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS Migrate: victory-group #2396

Merged
merged 9 commits into from
Aug 15, 2022
Merged

Conversation

sblinde
Copy link
Contributor

@sblinde sblinde commented Jul 29, 2022

Description

This PR migrates victory-group to TypeScript.

@sblinde sblinde added the Type: TypeScript Issues related to typescript or type definitions label Jul 29, 2022
@sblinde sblinde self-assigned this Jul 29, 2022
@sblinde sblinde mentioned this pull request Aug 2, 2022
30 tasks
@sblinde sblinde marked this pull request as draft August 3, 2022 14:19
@scottrippey scottrippey force-pushed the feature/migrate-victory-group-to-ts branch from bffc88d to dfdf236 Compare August 5, 2022 21:24
@scottrippey scottrippey marked this pull request as ready for review August 5, 2022 22:21
@scottrippey scottrippey requested a review from gksander August 10, 2022 17:29
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottrippey scottrippey merged commit 4c71518 into main Aug 15, 2022
@scottrippey scottrippey deleted the feature/migrate-victory-group-to-ts branch August 15, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: TypeScript Issues related to typescript or type definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants