Chore: Update lint and corresponding files.

.changeset/perfect-schools-hammer.md

@@ -0,0 +1,29 @@
+---
+"victory-area": patch
+"victory-axis": patch
+"victory-bar": patch
+"victory-box-plot": patch
+"victory-brush-container": patch
+"victory-brush-line": patch
+"victory-candlestick": patch
+"victory-canvas": patch
+"victory-core": patch
+"victory-create-container": patch
+"victory-cursor-container": patch
+"victory-errorbar": patch
+"victory-legend": patch
+"victory-line": patch
+"victory-pie": patch
+"victory-polar-axis": patch
+"victory-scatter": patch
+"victory-selection-container": patch
+"victory-shared-events": patch
+"victory-stack": patch
+"victory-tooltip": patch
+"victory-vendor": patch
+"victory-voronoi": patch
+"victory-voronoi-container": patch
+"victory-zoom-container": patch
+---
+
+Update source code with minor lint-based improvements (see #2236).

.eslintrc.js

@@ -1,3 +1,6 @@
+const path = require("path");
+const BABEL_PATH = path.resolve(__dirname, ".babelrc.js"); // eslint-disable-line no-undef
+
 module.exports = {
   settings: {
     react: {
@@ -11,22 +14,30 @@ module.exports = {
   },
   extends: [
     "formidable/configurations/es6-react",
-    "prettier",
     "plugin:react-hooks/recommended",
     "plugin:eslint-comments/recommended",
+    "prettier",
   ],
   rules: {
     "eslint-comments/disable-enable-pair": "off",
     "func-style": "off",
+    "arrow-body-style": "off",
+    "consistent-return": "off", // we're migrating to TS and this is more properly handled there.
     "react/sort-comp": "off",
-    "import/no-unresolved": [2, { ignore: ["victory*"] }],
-    "max-statements": 0,
+    "import/no-unresolved": ["error", { ignore: ["victory*"] }],
+    "max-statements": "off",
     complexity: ["error", { max: 16 }],
     "no-magic-numbers": [
       "error",
       { ignore: [-1, 0, 0.5, 1, 2, 90, 180, 270, 360] },
     ],
   },
+  parser: "@babel/eslint-parser",
+  parserOptions: {
+    babelOptions: {
+      configFile: BABEL_PATH,
+    },
+  },
   plugins: ["jest"],
   env: {
     "jest/globals": true,
@@ -36,9 +47,9 @@ module.exports = {
       files: ["**/*.test.*", "./test/**/*"],
       rules: {
         "react/sort-comp": "off",
-        "no-magic-numbers": 0,
-        "max-statements": 0,
-        "import/no-unresolved": 0,
+        "no-magic-numbers": "off",
+        "max-statements": "off",
+        "import/no-unresolved": "off",
         "no-undef": "off",
         "max-nested-callbacks": "off",
         "@typescript-eslint/no-empty-function": "off",

.github/ISSUE_TEMPLATE/victory-turbo-component-re-write.md

@@ -8,7 +8,7 @@ assignees: ''
 ---
 
 ## Implementation Notes
-- New components should live inside a nested director (currently v37). These components should not make changes to existing functionality.
+- New components should live inside a nested directory (currently v37). These components should not make changes to existing functionality.
 - The victory event system will be excluded for now until we have more clarity on how Victory wants to handle events.
 - [Add other notes here]
 

CONTRIBUTING.md

@@ -198,6 +198,8 @@ This task also watches and rebuilds all Victory source files so you can more eas
 $ pnpm run chromatic
 ```
 
+Note that Chromatic internally runs `npm run build-storybook` around which we have a custom `package.json:scripts.build-storybook` task that is meant to work within Chromatic.
+
 ## Release
 
 We use [changesets](https://github.com/changesets/changesets) to create package versions and publish them.

config/webpack/webpack.config.js

@@ -19,7 +19,7 @@ if (!libPath) {
 // PascalCase (with first character capitalized).
 const libName = libPath
   .replace(/^\s+|\s+$/g, "")
-  .replace(/(^|[-_ ])+(.)/g, function (match, first, second) {
+  .replace(/(^|[-_ ])+(.)/g, (match, first, second) => {
     // Second match group is the character we want to change. Throw away first.
     return second.toUpperCase();
   });

demo/js/app.js

@@ -1,5 +1,5 @@
-/*global document:false window:false */
-/*eslint-disable react/no-multi-comp */
+
+/* eslint-disable react/no-multi-comp */
 import React from "react";
 import ReactDOM from "react-dom";
 import { keys } from "lodash";

demo/js/components/accessibility-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryGroup } from "victory-group";
 import { VictoryStack } from "victory-stack";
@@ -327,7 +327,7 @@ export default class App extends React.Component {
             </VictoryChart>
           </div>
 
-          {/**ACCESSIBLE GROUP */}
+          {/** ACCESSIBLE GROUP */}
           <div style={chartContainerStyle}>
             <h2 style={chartHeadingStyle}>Accessible Group</h2>
             <VictoryChart domainPadding={{ x: 40 }}>

demo/js/components/animation-demo.js

@@ -1,5 +1,4 @@
-/*global window:false */
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { random, range } from "lodash";
 import { VictoryBar } from "victory-bar";

demo/js/components/canvas-demo.js

@@ -1,5 +1,4 @@
 /* eslint-disable no-magic-numbers */
-/*global window:false */
 import React from "react";
 import {
   CanvasGroup,

demo/js/components/create-container-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers,react/no-multi-comp */
+/* eslint-disable no-magic-numbers,react/no-multi-comp */
 import React from "react";
 import PropTypes from "prop-types";
 import { round } from "lodash";

demo/js/components/debug-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 
 import React from "react";
 import { VictoryChart } from "victory-chart";

demo/js/components/draggable-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers,react/no-multi-comp */
+/* eslint-disable no-magic-numbers,react/no-multi-comp */
 
 import React from "react";
 import { VictoryChart } from "victory-chart";

demo/js/components/events-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/js/components/external-events-demo.js

@@ -1,5 +1,4 @@
-/*eslint-disable no-magic-numbers */
-/*global window:false*/
+/* eslint-disable no-magic-numbers */
 
 import React from "react";
 import { VictoryChart } from "victory-chart";

demo/js/components/group-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/js/components/horizontal-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 
 import React from "react";
 import { VictoryChart } from "victory-chart";

demo/js/components/immutable-demo.js

@@ -1,4 +1,3 @@
-/* global window:false */
 /* eslint-disable no-magic-numbers, react/no-multi-comp */
 import React from "react";
 import PropTypes from "prop-types";

demo/js/components/performance.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { range } from "lodash";
 import { VictorySelectionContainer } from "victory-selection-container";

demo/js/components/selection-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/js/components/victory-area-demo.js

@@ -1,5 +1,4 @@
-/*global window:false */
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { merge, random, range } from "lodash";
 import { VictoryChart } from "victory-chart";

demo/js/components/victory-axis-demo.js

@@ -1,5 +1,4 @@
-/*global window:false */
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryAxis } from "victory-axis";
 import {

demo/js/components/victory-bar-demo.js

@@ -1,5 +1,4 @@
-/*global window:false*/
-/*eslint-disable no-magic-numbers,react/no-multi-comp */
+/* eslint-disable no-magic-numbers,react/no-multi-comp */
 import React from "react";
 import PropTypes from "prop-types";
 import { VictoryChart } from "victory-chart";

demo/js/components/victory-box-plot-demo.js

@@ -1,5 +1,4 @@
-/*global window:false */
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryBoxPlot } from "victory-box-plot";

demo/js/components/victory-brush-container-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/js/components/victory-brush-line-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 
 import React from "react";
 import { VictoryChart } from "victory-chart";

demo/js/components/victory-candlestick-demo.js

@@ -1,5 +1,4 @@
-/*global window:false */
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import PropTypes from "prop-types";
 import { random, range, merge } from "lodash";

demo/js/components/victory-chart-demo.js

@@ -1,5 +1,4 @@
-/*global window:false */
-/*eslint-disable no-magic-numbers,react/no-multi-comp */
+/* eslint-disable no-magic-numbers,react/no-multi-comp */
 import React from "react";
 import PropTypes from "prop-types";
 import { assign, merge, random, range, omit } from "lodash";

demo/js/components/victory-cursor-container-demo.js

@@ -1,5 +1,4 @@
-/*global window:false*/
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { random, range, round } from "lodash";
 import { VictoryChart } from "victory-chart";

demo/js/components/victory-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers*/
+/* eslint-disable no-magic-numbers*/
 import React from "react";
 import {
   VictoryAxis,

demo/js/components/victory-errorbar-demo.js

@@ -1,5 +1,4 @@
-/*global window:false */
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import PropTypes from "prop-types";
 import { assign, merge, random, range } from "lodash";

demo/js/components/victory-histogram-demo.js

@@ -1,5 +1,4 @@
-/*global window:false */
-/*eslint-disable no-magic-numbers,react/no-multi-comp */
+/* eslint-disable no-magic-numbers,react/no-multi-comp */
 import React from "react";
 import { merge, random, range } from "lodash";
 import { VictoryChart } from "victory-chart";

demo/js/components/victory-label-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers*/
+/* eslint-disable no-magic-numbers*/
 import React from "react";
 import { VictoryScatter } from "victory-scatter";
 import { VictoryLabel } from "victory-core";

demo/js/components/victory-line-demo.js

@@ -1,5 +1,4 @@
-/*global window:false */
-/*eslint-disable no-magic-numbers,react/no-multi-comp */
+/* eslint-disable no-magic-numbers,react/no-multi-comp */
 import React from "react";
 import PropTypes from "prop-types";
 import { merge, random, range } from "lodash";

demo/js/components/victory-pie-demo.js

@@ -1,5 +1,4 @@
-/*global window:false*/
-/*eslint-disable no-magic-numbers,react/no-multi-comp*/
+/* eslint-disable no-magic-numbers,react/no-multi-comp*/
 import { random, range } from "lodash";
 import React from "react";
 import { VictoryPie } from "victory-pie";

demo/js/components/victory-polar-chart-demo.js

@@ -1,5 +1,4 @@
-/*global window:false*/
-/*eslint no-magic-numbers:0*/
+/* eslint no-magic-numbers:0*/
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/js/components/victory-scatter-demo.js

@@ -1,5 +1,4 @@
-/*global window:false */
-/*eslint-disable no-magic-numbers,react/no-multi-comp */
+/* eslint-disable no-magic-numbers,react/no-multi-comp */
 import React from "react";
 import PropTypes from "prop-types";
 import { assign, merge, random, range } from "lodash";

demo/js/components/victory-tooltip-demo.js

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/js/components/victory-voronoi-container-demo.js

@@ -1,5 +1,4 @@
-/*global window:false*/
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/js/components/victory-voronoi-demo.js

@@ -1,5 +1,4 @@
-/*global window:false */
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryVoronoi } from "victory-voronoi";
 import { VictoryTooltip } from "victory-tooltip";

demo/js/components/victory-zoom-container-demo.js

@@ -1,5 +1,4 @@
-/* globals window */
-/*eslint-disable no-magic-numbers,react/no-multi-comp */
+/* eslint-disable no-magic-numbers,react/no-multi-comp */
 import React from "react";
 import PropTypes from "prop-types";
 import { range, merge, random, minBy, maxBy, last } from "lodash";

demo/ts/components/accessibility-demo.tsx

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { isNumber } from "lodash";
 import { VictoryGroup } from "victory-group";
@@ -80,7 +80,7 @@ export default class VictoryAccessibilityDemo extends React.Component<any> {
           <h3>Tabbable charts with aria-labels</h3>
         </div>
         <div className="demo" style={containerStyle}>
-          {/**BAR */}
+          {/** BAR */}
           <div
             style={chartContainerStyle}
             data-testid="bar-accessibility-chart"
@@ -351,7 +351,7 @@ export default class VictoryAccessibilityDemo extends React.Component<any> {
             </VictoryChart>
           </div>
 
-          {/**ACCESSIBLE GROUP */}
+          {/** ACCESSIBLE GROUP */}
           <div style={chartContainerStyle}>
             <h3 style={chartHeadingStyle}>Accessible Group</h3>
             <VictoryChart domainPadding={{ x: 40 }}>

demo/ts/components/draggable-demo.tsx

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers,react/no-multi-comp */
+/* eslint-disable no-magic-numbers,react/no-multi-comp */
 
 import React from "react";
 import { merge } from "lodash";

demo/ts/components/events-demo.tsx

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/ts/components/group-demo.tsx

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/ts/components/horizontal-demo.tsx

@@ -1,4 +1,4 @@
-/*eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers */
 
 import React from "react";
 import { VictoryChart } from "victory-chart";