Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: Migrate victory-cursor-container #2419

Merged
merged 6 commits into from
Aug 11, 2022
Merged

TS: Migrate victory-cursor-container #2419

merged 6 commits into from
Aug 11, 2022

Conversation

scottrippey
Copy link
Member

What

Migrate victory-cursor-container to TS.

This includes a fix for #2402.

@scottrippey scottrippey requested a review from gksander August 10, 2022 19:50
@scottrippey scottrippey mentioned this pull request Aug 10, 2022
Closed
gksander
gksander approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Perhaps we also throw a changeset in here?

@scottrippey scottrippey merged commit 06f5c73 into main Aug 11, 2022
@scottrippey scottrippey deleted the ts-migrate/victory-cursor-container branch August 11, 2022 21:34
@scottrippey scottrippey mentioned this pull request Aug 11, 2022
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gksander gksander gksander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottrippey @gksander