-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aria-hidden flag to svg for textsize util to fix accessibility issue #2661
Add aria-hidden flag to svg for textsize util to fix accessibility issue #2661
Conversation
🦋 Changeset detectedLatest commit: 37a08cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@boygirl @ryan-roemer are you all still supporting Victory Charts after your acquisition? we would love to get this blocker merged! |
Hi @danidewitt @noranda , thanks for the Pull Request. I will review this today. |
@carbonrobot can you also look at this issue, please? we have a couple accessibility blockers right now (that issue and this PR) |
Merging. CI Passed, Chromatic will not run on forked commits due to security policy. |
Thank you!! |
Thank you! 🥇 |
The
testsize
util creates a hidden SVG element, but does not setaria-hidden
totrue
, which causes accessibility issues. This PR simply adds the attribute.