Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-hidden flag to svg for textsize util to fix accessibility issue #2661

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

noranda
Copy link
Contributor

@noranda noranda commented Oct 12, 2023

The testsize util creates a hidden SVG element, but does not set aria-hidden to true, which causes accessibility issues. This PR simply adds the attribute.

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: 37a08cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-core Patch
victory Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 5:14pm

@danidewitt
Copy link

danidewitt commented Oct 18, 2023

@boygirl @ryan-roemer are you all still supporting Victory Charts after your acquisition? we would love to get this blocker merged!

@carbonrobot
Copy link
Contributor

Hi @danidewitt @noranda , thanks for the Pull Request. I will review this today.

@danidewitt
Copy link

@carbonrobot can you also look at this issue, please? we have a couple accessibility blockers right now (that issue and this PR)

@carbonrobot
Copy link
Contributor

Merging. CI Passed, Chromatic will not run on forked commits due to security policy.

@carbonrobot carbonrobot merged commit c8381aa into FormidableLabs:main Oct 18, 2023
2 checks passed
@noranda noranda deleted the noranda/fix-hidden-svg branch October 18, 2023 17:50
@noranda
Copy link
Contributor Author

noranda commented Oct 18, 2023

Thank you!!

@danidewitt
Copy link

Thank you! 🥇

@victory-ci victory-ci mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants