Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish aggregate release notes to Github #2670

Merged
merged 5 commits into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,12 @@ jobs:
# https://github.com/changesets/action/issues/187
GITHUB_TOKEN: ${{ secrets.CHANGESETS_GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

# Note: We run a custom release notes script so we can generate a single aggregate
# release notes file for all packages. This can be removed when `changesets` supports
# this feature natively.
- name: Github Release notes
if: steps.changesets.outputs.published == 'true'
run: npm run release-notes
env:
GITHUB_TOKEN: ${{ secrets.CHANGESETS_GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion package-scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ module.exports = {
// - Jest
// TODO(2375): Can we cache / incremental?
// https://github.com/FormidableLabs/victory/issues/2375
"jest:native": `cross-env BABEL_ENV=commonjs jest --config=../../test/jest-native-config.js --testPathPattern=${PKG_SRC}`,
"jest:native": `cross-env BABEL_ENV=commonjs jest --config=../../test/jest-native-config.js --passWithNoTests --testPathPattern=${PKG_SRC}`,
"jest:pkg": `cross-env BABEL_ENV=commonjs jest --config=../../test/jest-config.js --passWithNoTests --testPathPattern=${PKG_SRC}`,
// TODO(2348): Hook coverage up to CI
// https://github.com/FormidableLabs/victory/issues/2348
Expand Down
11 changes: 10 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"@testing-library/react": "^13.3.0",
"@testing-library/react-hooks": "^8.0.0",
"@testing-library/react-native": "^11.0.0",
"@types/fs-extra": "^11.0.3",
"@types/jest": "^28.1.6",
"@types/lodash": "^4.14.149",
"@types/node": "^18.6.1",
Expand Down Expand Up @@ -82,26 +83,33 @@
"eslint-plugin-promise": "^6.0.0",
"eslint-plugin-react": "^7.0.0",
"eslint-plugin-react-hooks": "^4.2.0",
"fs-extra": "^10.0.0",
"glob": "8.0.3",
"immutable": "^3.8.2",
"jest": "^28.1.3",
"jest-environment-jsdom": "^28.1.3",
"lodash": "^4.17.19",
"lodash-webpack-plugin": "^0.11.6",
"mdast-util-to-string": "^1.0.6",
"metro-react-native-babel-preset": "0.71.3",
"nps": "^5.9.0",
"octokit": "^3.1.1",
"prettier": "^2.6.2",
"prop-types": "^15.8.1",
"react": "^18.1.0",
"react-dom": "^18.1.0",
"react-hot-loader": "4.13.0",
"react-test-renderer": "^18.1.0",
"remark-parse": "^7.0.1",
"remark-stringify": "^7.0.3",
"rimraf": "^3.0.2",
"seedrandom": "^3.0.5",
"styled-components": "^5.3.5",
"ts-jest": "^28.0.7",
"ts-loader": "^9.3.0",
"ts-node": "^10.9.1",
"typescript": "^4.7.3",
"unified": "^8.3.2",
"victory-vendor": "*",
"victory-voronoi": "*",
"webpack": "^5.74.0",
Expand Down Expand Up @@ -156,7 +164,8 @@
"chromatic:ci": "wireit",
"sync": "wireit",
"sync:pkgs": "node ./scripts/sync-pkgs-wireit.js",
"sync:tsconfig": "pnpm -r --filter !victory-core --filter !victory-vendor exec -- cpx ../victory-core/tsconfig.* ."
"sync:tsconfig": "pnpm -r --filter !victory-core --filter !victory-vendor exec -- cpx ../victory-core/tsconfig.* .",
"release-notes": "ts-node ./scripts/release.ts"
},
"wireit": {
"clean:cache": {
Expand Down
Loading