Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a holiday animation example #2681

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Add a holiday animation example #2681

merged 2 commits into from
Dec 19, 2023

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Dec 19, 2023

Add a fun holiday example to the Gallery!

Also updates the opengraph metadata for Gallery pages so we can share these properly in Social networks

santa

Copy link

changeset-bot bot commented Dec 19, 2023

⚠️ No Changeset found

Latest commit: ab559c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 9:11pm

@carloskelly13
Copy link

This is great, but I'm seeing a bit of sizing problems with overflow on the gallery page.

Screenshot 2023-12-19 at 3 01 52 PM

@carbonrobot
Copy link
Contributor Author

@carloskelly13 Yeah, thats a consistent problem with our entire gallery... I'll see what I can do.

@carloskelly13
Copy link

I wonder if a quick fix is a poster screenshot of the animation.

@carbonrobot
Copy link
Contributor Author

@carloskelly13 fixed by hiding the overflow for the container. This fixes it for all items.

image

Copy link

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho ho ho 🎄

@carbonrobot carbonrobot merged commit 1e58a0b into main Dec 19, 2023
4 checks passed
@carbonrobot carbonrobot deleted the feature/holiday-animation branch December 19, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants