Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the label background position when using dy fns #2720

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Jan 16, 2024

When using a user provided function for the label dy property, the component was not correctly calculating the new y offset based on the original position.

Added a new storybook use case so Chromatic can track this as well

Before

before

After

after

Fixes #2715

Copy link

changeset-bot bot commented Jan 16, 2024

🦋 Changeset detected

Latest commit: 1bf75eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-core Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 4:47pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect positioning of a VictoryLabel's background when its dy is a function
2 participants